Skip to content

chore: upgrade angular 21#3775

Merged
fpaul-1A merged 1 commit intorelease/14.0.0-nextfrom
chore/angular-21
Jan 13, 2026
Merged

chore: upgrade angular 21#3775
fpaul-1A merged 1 commit intorelease/14.0.0-nextfrom
chore/angular-21

Conversation

@fpaul-1A
Copy link
Copy Markdown
Contributor

@fpaul-1A fpaul-1A commented Dec 1, 2025

Proposed change

Missing:

  • ngx-markdown still has a peer dependency on zone.js
    -> non-blocking, issue is tracked here Zone.js as optional dependency jfcere/ngx-markdown#524
  • @nx/angular not updated to angular 21
    -> fixed in 22.3.0
  • design-factory, @agnos-ui/angular-bootstrap not updated to angular 21
    -> non-blocking
  • jest-preset-angular not updated to angular 21
    -> fixed in 16.0
  • @ngrx/router-store not updated to angular 21
    -> updated in 21.0.0
  • @angular-builders/jest not updated to angular 21
    -> fixed in 21.0.0-beta
  • ngx-monaco-editor-v2 not updated to angular 21
    -> non-blocking, pull-request opened here fix bugs and move to angular 21 miki995/ngx-monaco-editor-v2#44

Related issues

- No issue associated -

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Dec 1, 2025

View your CI Pipeline Execution ↗ for commit 4e11f06

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 1h 35m 7s View ↗
nx run-many --tui=false --target=build --projec... ✅ Succeeded 1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 2m 11s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 58s View ↗
nx run-many --target=prepare-publish --exclude-... ✅ Succeeded 7s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 12m 43s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-13 12:23:37 UTC

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2025

⚠️ Yarn detected 20 errors during the install process.


List of reported errors
Error Description
YN0060 @angular/common is listed by your project with version 21.0.8 (p621092), which doesn't satisfy what @agnos-ui/angular-bootstrap and other dependencies request (but they have non-overlapping ranges!).
YN0060 @angular/common is listed by your project with version 21.0.8 (p68e77d), which doesn't satisfy what @agnos-ui/angular-bootstrap and other dependencies request (but they have non-overlapping ranges!).
YN0060 @angular/common is listed by your project with version 21.0.8 (pcc4255), which doesn't satisfy what @agnos-ui/angular-bootstrap and other dependencies request (but they have non-overlapping ranges!).
YN0060 @angular/core is listed by your project with version 21.0.8 (p7f8bc5), which doesn't satisfy what @agnos-ui/angular-bootstrap and other dependencies request (but they have non-overlapping ranges!).
YN0060 @angular/core is listed by your project with version 21.0.8 (pd72d44), which doesn't satisfy what @agnos-ui/angular-bootstrap and other dependencies request (but they have non-overlapping ranges!).
YN0060 @angular/core is listed by your project with version 21.0.8 (pe7323c), which doesn't satisfy what @agnos-ui/angular-bootstrap and other dependencies request (but they have non-overlapping ranges!).
YN0060 @angular/localize is listed by your project with version 21.0.8 (p3fec24), which doesn't satisfy what @design-factory/design-factory and other dependencies request (but they have non-overlapping ranges!).
YN0060 @angular/localize is listed by your project with version 21.0.8 (p619a56), which doesn't satisfy what @design-factory/design-factory and other dependencies request (but they have non-overlapping ranges!).
YN0060 @angular/localize is listed by your project with version 21.0.8 (p7feb5b), which doesn't satisfy what @design-factory/design-factory and other dependencies request (but they have non-overlapping ranges!).
YN0060 @angular/router is listed by your project with version 21.0.8 (p25cf91), which doesn't satisfy what @design-factory/design-factory and other dependencies request (but they have non-overlapping ranges!).
YN0060 @angular/router is listed by your project with version 21.0.8 (p41afbc), which doesn't satisfy what @design-factory/design-factory and other dependencies request (but they have non-overlapping ranges!).
YN0060 @angular/router is listed by your project with version 21.0.8 (pcd59b1), which doesn't satisfy what @design-factory/design-factory and other dependencies request (but they have non-overlapping ranges!).
YN0060 @ng-bootstrap/ng-bootstrap is listed by your project with version 20.0.0 (p6b5676), which doesn't satisfy what @design-factory/design-factory requests (~19.0.0).
YN0060 @ng-bootstrap/ng-bootstrap is listed by your project with version 20.0.0 (p9014f4), which doesn't satisfy what @design-factory/design-factory requests (~19.0.0).
YN0060 @ng-bootstrap/ng-bootstrap is listed by your project with version 20.0.0 (padcd1f), which doesn't satisfy what @design-factory/design-factory requests (~19.0.0).
YN0060 @ng-select/ng-select is listed by your project with version 21.1.4 (p1021d3), which doesn't satisfy what @design-factory/design-factory requests (**^15.0.0
YN0060 @ng-select/ng-select is listed by your project with version 21.1.4 (p5f2d63), which doesn't satisfy what @design-factory/design-factory requests (**^15.0.0
YN0060 @ng-select/ng-select is listed by your project with version 21.1.4 (peb7ed3), which doesn't satisfy what @design-factory/design-factory requests (**^15.0.0
YN0002 @o3r/framework@workspace:. doesn't provide zone.js (pff1090), requested by @angular/core and other dependencies.
YN0002 @o3r/showcase@workspace:apps/showcase doesn't provide zone.js (p978252), requested by @angular/core and other dependencies.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.82%. Comparing base (e7e9e37) to head (4e11f06).
⚠️ Report is 2 commits behind head on release/14.0.0-next.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/tools/component-replacement/c11n-directive.ts 0.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/@o3r/analytics/tsconfig.spec.json
Comment thread packages/@o3r/testing/eslint.local.config.mjs Outdated
Comment thread packages/@o3r/testing/tsconfig.builders.json Outdated
Comment thread packages/@o3r/workspace/schematics/application/templates/package.json.template Outdated
: {
'@types/jasmine': o3rWorkspacePackageJson.generatorDependencies!['@types/jasmine']
},
: (options.useVitest
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it documented somewhere that useJest takes priority over useVitest?
I see a potential issue in the current implementation. Even if you choose vitest in options.testingFramework, but you have a leftover dependency that contains jest (or the package name, or description etc) you will stil use jest. Maybe not to be tackled in this PR but, it might be worth to track it via an issue

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll have to do some more tests for sure to validate that everything works fine with jest/vitest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project:@ama-mcp/angular project:@ama-mcp/core project:@ama-mcp/github project:@ama-mcp/otter project:@ama-mfe/messages project:@ama-mfe/ng-utils project:@ama-sdk/client-angular project:@ama-sdk/client-beacon project:@ama-sdk/client-fetch project:@ama-sdk/core project:@ama-sdk/create project:@ama-sdk/schematics project:@ama-sdk/swagger-builder project:@ama-styling/figma-extractor project:@ama-styling/figma-sdk project:@ama-styling/style-dictionary project:@ama-styling/stylelint-plugin project:@ama-terasu/cli project:@ama-terasu/core project:@ama-terasu/schematics project:audit-gh-action project:get-npm-tag-gh-action project:new-version-gh-action project:@o3r/amaterasu-api-spec project:@o3r/amaterasu-dodo project:@o3r/amaterasu-otter project:@o3r/amaterasu-sdk project:@o3r/analytics project:@o3r/apis-manager project:@o3r/application project:@o3r/artifactory-tools project:@o3r/azure-tools project:@o3r/build-helpers project:@o3r/chrome-devtools project:@o3r/components project:@o3r/configuration project:@o3r/core project:@o3r/create project:@o3r/design project:@o3r/dynamic-content project:@o3r/eslint-config project:@o3r/eslint-plugin project:@o3r/extractors project:@o3r/forms project:@o3r/github-cascading-app project:@o3r/localization project:@o3r/logger project:@o3r/mcp project:@o3r/mobile project:@o3r/new-version project:@o3r/palette-generator project:@o3r/pipeline project:@o3r/routing project:@o3r/rules-engine project:@o3r/schematics project:@o3r/showcase project:@o3r/store-sync project:@o3r/style-dictionary project:@o3r/stylelint-plugin project:@o3r/styling project:@o3r/telemetry project:@o3r/test-helpers project:@o3r/testing project:@o3r/third-party project:@o3r/workspace project:@o3r/workspace-helpers project:@o3r-training/showcase-sdk project:@o3r-training/training-sdk project:@o3r-training/training-tools project:otter-devtools project:release-gh-action project:yarn-errors-reporter-gh-action runAllTests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants