Fix for issue-33 : handling required field #59
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszm
reviewed
Oct 3, 2022
| } else if (node instanceof LeafSchemaNode) { | ||
| LeafSchemaNode lN = (LeafSchemaNode) node; | ||
| prop = getPropertyByType(lN); | ||
| if (prop != null) { |
Collaborator
There was a problem hiding this comment.
why did you decided to set required only for simple fields? Swagger allows you to define it at any property as well as YANG defines it at DataSchemaNode so it can be applied for all types of nodes
bartoszm
requested changes
Oct 3, 2022
Collaborator
bartoszm
left a comment
bartoszm
left a comment
There was a problem hiding this comment.
Thank you for the contribution - so far so good.
However, I have a suggestion for how the required field should be implemented.
In addition, I would expect to see unit tests for the functionality you add.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for setting fields as required. It works fine even after converting to OASv3.x, please review..