skip empty arguments (#2)

[Divyanshubansaldb]

• skip empty arguments when building request params

Summary by Sourcery

Bug Fixes:

• Omit header and query arguments whose values are empty strings or nil

[sourcery-ai]

Reviewer's Guide

Adds logic to skip empty or nil argument values when building HTTP request parameters by checking for empty strings or "" and continuing the loop to avoid sending empty headers or params.

Class diagram for updated argument processing in HTTP request

classDiagram
    class Server {
        +prepareRequest(tool, tmplCtx)
    }
    class ToolConfig {
        Args
    }
    class Argument {
        Name
        Position
    }
    class http.Request {
        Header
    }
    Server -- ToolConfig : uses
    ToolConfig "1" -- "*" Argument : has
    Server ..> http.Request : prepares

    %% Highlight processArguments logic
    class processArguments {
        +processArguments(req, tool, args)
        // Now skips empty or "<nil>" argument values
    }
    Server ..> processArguments : calls
    processArguments ..> http.Request : modifies
    processArguments ..> ToolConfig : reads Args
    processArguments ..> Argument : iterates

Loading

File-Level Changes

Change	Details	Files
Skip empty and nil arguments when populating request parameters	Add conditional to detect empty string or "" values Continue loop for these values to prevent setting empty headers/params	internal/core/tool.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Divyanshubansaldb - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}