Remove caching from repos #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use django orm in repo methods
pstokkink
force-pushed
the
pieter/uncache
branch
from
4e8ecfc to
46b233f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dit was een probleem omdat we meerdere pods hebben draaien en writes naar de ene natuurlijk niet de cache van de ander invalideerde. Voor nu cache verwijderd, we halen nu gewoon op wat we nodig hebben wanneer we het nodig hebben.
Een andere mogelijkheid zou CQRS zijn, maar dat is nog een stuk meer werk en vereist ook werk aan frontend, omdat we bij writes standaard niet meer het hele object zouden teruggeven. Is wellicht wel iets om naar toe te werken.
NB, voor het product list endpoint halen we voor nu alles op; de volgordelijkheid icm complexe queries was even niet snel op te lossen.