Skip to content

Conversation

aivus
Copy link

@aivus aivus commented Dec 3, 2023

Hello

I noticed that in case 188 attribute has value 0 it is shown as warn with the Could not determine Observed Failure Rate for Critical Attribute tooltip.

This is happening because comparison logic in smart_ata_attribute.go doesn't include low value. But in case low == high bucket will be selected.

@AnalogJ
Copy link
Owner

AnalogJ commented Dec 5, 2023

I think updating the threshold logic makes more sense than creating a 0,0 bucket. What do you think?

@aivus
Copy link
Author

aivus commented Jan 7, 2024

I'll try to find time to rework logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants