Skip to content

Full custom for HP and other hardware raid's #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Full custom for HP and other hardware raid's #724

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f694271
Update config.go
Ziut3k-dev Nov 26, 2024
6aee6a4
Merge branch 'master' into patch-1
Ziut3k-dev Dec 10, 2024
fef77a2
Merge branch 'master' into patch-1
Ziut3k-dev Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions collector/pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ func (c *configuration) Init() error {
c.SetDefault("commands.metrics_info_args", "--info --json")
c.SetDefault("commands.metrics_smart_args", "--xall --json")
c.SetDefault("commands.metrics_smartctl_wait", 0)

c.SetDefault("commands.allow_custom", "no")

//configure env variable parsing.
c.SetEnvPrefix("COLLECTOR")
c.SetEnvKeyReplacer(strings.NewReplacer("-", "_", ".", "_"))
c.AutomaticEnv()

//c.SetDefault("collect.short.command", "-a -o on -S on")

c.SetDefault("allow_listed_devices", []string{})
Expand Down Expand Up @@ -103,11 +103,13 @@ func (c *configuration) ReadConfig(configFilePath string) error {

// This function ensures that the merged config works correctly.
func (c *configuration) ValidateConfig() error {

//TODO:
// check that device prefix matches OS
// check that schema of config file is valid

if(c.GetString("commands.allow_custom")=="yes"){
return nil
}
// check that the collector commands are valid
commandArgStrings := map[string]string{
"commands.metrics_scan_args": c.GetString("commands.metrics_scan_args"),
Expand Down