add defaultState option to set a fallback alarm panel state#22
Draft
cupracer wants to merge 1 commit intoAnamico:masterfrom
Draft
add defaultState option to set a fallback alarm panel state#22cupracer wants to merge 1 commit intoAnamico:masterfrom
cupracer wants to merge 1 commit intoAnamico:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alarm panel defaults to a hard-coded
0state ("Home" mode), which immediately would result in an alarm after restarting Node-RED in case a "Home"-sensor triggers at this time.I would like to avoid enabling the default use of persistent storage for global context variables. It would be sufficient for my environment to just start with a disabled alarm panel (state
3) instead of "Home"-mode (state0).To achieve this I extended the code to have a default/fallback state configurable instead of having it hard-coded to
0. It would be used whenever Node-RED is started without an existing global'SecuritySystemCurrentState_' + node.nodeIdvariable.This
defaultStateoption as well defaults to0, so it shouldn't disturb existing setups.Note: For quite better solution to address this topic see #23 .