Skip to content

Add support for Ghostty#174

Open
fcurella wants to merge 2 commits intoAnonymouX47:mainfrom
fcurella:main
Open

Add support for Ghostty#174
fcurella wants to merge 2 commits intoAnonymouX47:mainfrom
fcurella:main

Conversation

@fcurella
Copy link
Copy Markdown

Ghostty was not detected as supporting the Kitty protocol.

@georgeharker
Copy link
Copy Markdown

This would be great and I can confirm it works well.

@bitbanger
Copy link
Copy Markdown

I made this same change myself and can confirm it works fine with ghostty 1.1.0.

@goto-dev-null
Copy link
Copy Markdown

Also confirmed that this works with Ghostty 1.2.3

Though would it make sense to adjust the comment so that it refers to both Konsole and Ghostty?

# Konsole and Ghostty are good as long as they responds to the graphics query

I honestly don't fully grok the comment; it just feels weird to have the comment only refer to Konsole after making the if include Ghostty.

The alternative would be to separate it out so that ghostty has its own elif, unsure as to which makes more sense.

@fcurella
Copy link
Copy Markdown
Author

I've updated the comment

Copy link
Copy Markdown

@goto-dev-null goto-dev-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants