Repository navigation
Report regex compile failures as invalid format, not crashes. - #1
Merged
Merged
Conversation
re.compile can raise ValueError, RecursionError, or OverflowError in addition to re.error; catch those so the regex format checker reports the instance as invalid instead of escaping uncaught. Fixes python-jsonschema#1538 Fixes python-jsonschema#1558
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
regexformat checker only treatedre.erroras an invalid instance.re.compilecan also raise:ValueErrorfor conflicting inline flags such as(?u)(?a)(#1558)RecursionErrorfor deeply nested patterns (#1538)OverflowErrorfor oversized repeat counts (#1526)Those exceptions escaped uncaught and crashed validation instead of reporting the string as an invalid regex.
This change declares those extra exception types on
is_regex, matching other format checkers that already pass an exception tuple.Fixes python-jsonschema#1538
Fixes python-jsonschema#1558
Test plan
jsonschema/tests/test_format.pyfor unterminated patterns, conflicting flags, deep nesting, oversized repeats, and a valid patternuv run --group test python -m virtue jsonschema.tests.test_formatuv run --group test python -m virtue jsonschema