feat: split jest test and e2e test#109
Closed
lumixraku wants to merge 8 commits intoAppFlowy-IO:mainfrom
Closed
Conversation
Reviewer's GuideThis PR splits the CI testing: E2E (Cypress) tests are moved to a new File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @lumixraku - I've reviewed your changes - here's some feedback:
- Please complete the PR description template to provide context for these changes.
- The removal of the MUI icon import plugin changes how icons are imported; ensure this new direct import pattern is consistently applied or documented.
- With E2E coverage moved to
e2e.yaml, consider renamingweb_coverage.yamlto more accurately reflect its now specific scope (e.g.,web_unit_coverage.yaml).
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
0f090a7 to
f228450
Compare
73dbca1 to
6073adf
Compare
85b268e to
11df05e
Compare
8c86e93 to
e59c460
Compare
appflowy
added a commit
that referenced
this pull request
Nov 14, 2025
Publish/Unpublish/visit Link Test
josue693
pushed a commit
to josue693/AppFlowy-Web
that referenced
this pull request
Dec 21, 2025
Publish/Unpublish/visit Link Test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the unit tests and E2E tests are currently in the same task. However, as the number of test cases is bound to increase in the future, the test execution time will become longer. I think Jest and E2E tests can be separated into two independent and parallel tasks.
Checklist
General
Testing
Feature-Specific
Summary by Sourcery
Split and improve test coverage configuration for AppFlowy Web project
Enhancements:
CI:
Tests:
Chores: