Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,15 @@ jobs:
run: test "$(uname -m)" = "${{ matrix.arch }}"
- run: cargo test --workspace --all-targets

cargo-deny:
name: cargo-deny
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: EmbarkStudios/cargo-deny-action@v2
with:
command: check

clippy-windows:
name: clippy (windows)
runs-on: windows-latest
Expand Down
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 37 additions & 0 deletions deny.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# cargo-deny configuration — advisories, licenses, and source hygiene for the
# whole dependency graph (including the git-pinned gpui/zed tree).
# Run locally with: nix run nixpkgs#cargo-deny -- check

[advisories]
yanked = "deny"

[licenses]
# Additions here need a conscious decision; keep the list to what the graph
# actually pulls in.
allow = [
"0BSD",
"CDLA-Permissive-2.0",
"MIT",
"Apache-2.0",
"Apache-2.0 WITH LLVM-exception",
"BSD-2-Clause",
"BSD-3-Clause",
"ISC",
"Zlib",
"Unicode-3.0",
"MPL-2.0",
"CC0-1.0",
]

[bans]
# The zed/gpui tree inevitably carries duplicate versions; keep this advisory
# rather than blocking.
multiple-versions = "warn"

[sources]
unknown-registry = "deny"
unknown-git = "deny"
allow-git = [
"https://github.com/zed-industries/zed",
"https://github.com/longbridge/gpui-component",
]
Comment on lines +34 to +37

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 security Git Source Allowlist Is Incomplete

With unknown-git = "deny", this list must cover every git source in Cargo.lock. The current lockfile also uses AprilNEA/gpui-updater, zed-industries/wgpu.git, zed-industries/xim-rs.git, zed-industries/font-kit, zed-industries/reqwest.git, and zed-industries/scap, so the new cargo-deny job can reject the existing dependency graph before it checks new changes.

Suggested change
allow-git = [
"https://github.com/zed-industries/zed",
"https://github.com/longbridge/gpui-component",
]
allow-git = [
"https://github.com/zed-industries/zed",
"https://github.com/longbridge/gpui-component",
"https://github.com/AprilNEA/gpui-updater",
"https://github.com/zed-industries/wgpu.git",
"https://github.com/zed-industries/xim-rs.git",
"https://github.com/zed-industries/font-kit",
"https://github.com/zed-industries/reqwest.git",
"https://github.com/zed-industries/scap",
]

Fix in Codex Fix in Claude Code

6 changes: 3 additions & 3 deletions devenv.lock
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@
]
},
"locked": {
"lastModified": 1779592685,
"narHash": "sha256-p9d56GezhHRf4QfANxwa1d+fvwShvjB5XUhdIl7WEd0=",
"lastModified": 1783144302,
"narHash": "sha256-NQnzmXwpEAd5tjMBh2+P/y9NknF+WHv5+6yoXoN4h/Y=",
"owner": "oxalica",
"repo": "rust-overlay",
"rev": "3a58b199e7c83a80b85c28044f808085ba7e941c",
"rev": "fe5aee0952e8e1525533d61defd9e36513db811b",
"type": "github"
},
"original": {
Expand Down
Loading