fix(server): close worker on shutdown and parse in_memory#178
Open
gnanirahulnutakki wants to merge 1 commit into
Open
fix(server): close worker on shutdown and parse in_memory#178gnanirahulnutakki wants to merge 1 commit into
gnanirahulnutakki wants to merge 1 commit into
Conversation
ARD-447: close the worker queue during graceful shutdown and join the worker thread instead of only logging. ARD-449: accept explicit ARDUR_MEMORY=in_memory and cover the literal with a unit test. Signed-off-by: Ardur <team@ardur.ai>
Member
Author
|
Local verification and required GitHub checks are green. Merge is currently blocked by base branch policy; auto-merge is unavailable for this repo, and I am not bypassing branch protection with admin privileges from this session. Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ARDUR_MEMORY=in_memoryand add a unit test for the literalIssues
Verification
cargo check -p ardur-server— passedcargo test -p ardur-server— passedcargo clippy --workspace --all-targets -- -D warnings— passedcargo test -p ardur-e2e-tests && cargo build --workspace --bins— passedSigned-off-by: Ardur team@ardur.ai