Open
Conversation
Don't substiture dashed corners, since there aren't any to draw.
This seems to look better and more consistent because the vertical-t breaks up the dotted vertical line.
Owner
|
Thanks! I am working in this review. I am also traveling at the moment, so please expect some delay. |
- Update tests expectations. - Add an entry to the CHANGELOG. - Revert change to examples. - Add dashed arrow examples. - Add an entry to the CHANGELOG. - Revert changes to the lines.
Author
|
Apologies for leaving a bit too much in. I was hoping you would see the direction I was wanting to go with this, and decided to leave it in for you to decide. Another part, Message::Draw() (beginning), I forgot about because I've made so many experiments. Perhaps I should open a Discussion for these other improvements instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've only really touched the Sequence diagrams.
Added a UNICODE filled arrowhead (both left & right), A vertical bar with either a left or right fork, and updated the 'dashed' character(s) for a little bit of a prettier look.
Also modified Screen::ASCIIfy() to include the newly added UNICODE chars and substitutions. Changed ASCIIfication of the vertical-t to just a plain vertical bar, matching the same done with the horizontal-t being replaced with a minus sign.
Added dotted lines to the last two examples (run "diagon Sequence --examples" to see).
Some Images
UNICODE (in VSCODE in WSL2)
ASCII
