Escape special characters in CSS class selectors#4
Merged
Conversation
Newer Unity USS parsers reject unescaped '.' and '/' in class selectors (e.g. .basis-1/2, .p-0.5). Add a CssEscape helper, register it as a Handlebars helper, and use it for every selector key in template.hbs so the generated output emits .basis-1\/2, .p-0\.5, etc. https://claude.ai/code/session_01Ub9WMzEk9DBUZxnrSMktLd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds CSS identifier escaping to the Breeze template compiler to properly handle special characters in configuration keys when generating CSS class selectors.
Key Changes
CssEscapeutility class: ImplementsIdentifier()method that escapes special characters (forward slashes, periods, colons, percent signs, etc.) in CSS identifiers by prefixing them with backslashes, while preserving valid CSS characters (letters, digits, hyphens, underscores)cssEscapehelper in theCompilerstatic constructor to make the escaping function available in Handlebars templatescssEscapehelper to all 40+ CSS class selector generation points in the template (backgrounds, borders, spacing, sizing, typography, etc.)CssEscapeTestsclass with 6 test cases covering forward slashes, periods, colons, percent signs, and edge casesCompilerTeststo verify that special characters in configuration keys are properly escaped in the compiled CSS outputImplementation Details
The
CssEscape.Identifier()method iterates through each character and escapes any character that isn't alphanumeric, a hyphen, or an underscore. This ensures that configuration keys like"1/2","0.5", and"hover:50%"generate valid CSS selectors like.basis-1\/2,.p-0\.5, and.hover\:50\%respectively.https://claude.ai/code/session_01Ub9WMzEk9DBUZxnrSMktLd