Add --ignore-avatars and --ignore-stickers CLI flags #1904
+90
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexelbie
force-pushed
the
feature_ignore_avatars_stickers
branch
from
e272437 to
6a12e3d
Compare
AsamK
requested changes
Jan 24, 2026
Owner
AsamK
left a comment
AsamK
left a comment
There was a problem hiding this comment.
Thanks, looks good. I have just one change request.
| dependencies.setAllowStories(!receiveConfig.ignoreStories()); | ||
| } | ||
|
|
||
| public ReceiveConfig getReceiveConfig() { |
Owner
There was a problem hiding this comment.
The ReceiveHelper shouldn't expose the ReceiveConfig. Instead the ProfileHelper, SyncHelper and GroupHelper should get a boolean value for ignoreAvatars
Author
There was a problem hiding this comment.
I've pushed a new patch that I believe resolves this.
bexelbie
force-pushed
the
feature_ignore_avatars_stickers
branch
from
6a12e3d to
4998a05
Compare
Implement two new CLI flags to disable downloading avatars and sticker packs during message reception, following the existing pattern of --ignore-attachments and --ignore-stories flags. Changes: - Add --ignore-avatars and --ignore-stickers flags to ReceiveCommand, DaemonCommand, and JsonRpcDispatcherCommand - Extend ReceiveConfig record with ignoreAvatars and ignoreStickers fields - Pass ignoreAvatars as explicit boolean parameter to ProfileHelper, SyncHelper, and GroupHelper methods (per maintainer feedback) - Gate avatar downloads in ProfileHelper (profile avatars), SyncHelper (contact avatars), and GroupHelper (group avatars for V1 and V2) - Gate sticker pack downloads in IncomingMessageHandler for both direct sticker messages and sync sticker pack operations - Update handleSignalServiceDataMessage and handleSyncMessage to pass full ReceiveConfig instead of individual boolean flags - Update man page (signal-cli.1.adoc) with flag documentation - Add entries to CHANGELOG.md When these flags are set, the respective content is not downloaded during message reception. Metadata (avatar paths, sticker pack IDs) is still stored, and existing FileNotFoundException handling will surface if content is later requested but wasn't downloaded. Fixes AsamK#1903
bexelbie
force-pushed
the
feature_ignore_avatars_stickers
branch
from
4998a05 to
ab7f34b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement two new CLI flags to disable downloading avatars and sticker packs during message reception, following the existing pattern of --ignore-attachments and --ignore-stories flags.
Changes:
When these flags are set, the respective content is not downloaded during message reception. Metadata (avatar paths, sticker pack IDs) is still stored, and existing FileNotFoundException handling will surface if content is later requested but wasn't downloaded.
Fixes #1903