Intro text to solar position algorithms #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@AdamRJensen, I think this is ready for review! |
kandersolar
reviewed
Aug 4, 2025
There was a problem hiding this comment.
A couple of comments:
- It is a shame that the Figure 1 uses a different azimuth convention (south=0) than the package, and even the calculated plots on this page.
- It seems a bit strange for the first solar position calculation to be done using a different package (pvlib) :P
echedey-ls
reviewed
Aug 11, 2025
….com/AssessingSolar/solposx into intro_text_solar_position_algorithms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3