-
Notifications
You must be signed in to change notification settings - Fork 2
Copy pvlib's SPA (NREL's) implementation #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There are a lot of functions in this PR. Should most of them be made private functions? @kandersolar How should we give credit / copyright to pvlib/you? |
If this code was modified from pvlib's code, we will need to also include pvlib's license, per this clause:
|
I midly changed my mind about having stand-alone implementations. We aren't going to rewrite others too and, except for that performance PR at pvlib, both algorithm and interface should be pretty stable. I guess I can instead wrap pvlib's call into a locally-documented public function and stop there. Pretty much like it has been made to other external-dep algorithms. While not cleaner (the code, I mean, with the numba decorators), it shouldn't be difficult to translate to other languages by navigating to the source. So, unless you object, I will change the scope of this PR, keep the fixed typo, link to pvlib's source, and unpin pvlib version from the docs optional dependency set. |
Sounds great to me! |
Closes #94
For extra control over the source code (and the docstring!), and easing a pure-python reference for translating into other languages. Numba has been stripped off, plus adding some other code stylisation and opinionated best practices.
Feel free to make any and all objections.