Skip to content

Conversation

@DaniilSmirnov
Copy link
Contributor

Hi! I add poetry instead of plain requirements.txt to enhance developer experience

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @DaniilSmirnov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant change to how Python dependencies are managed for the API, transitioning from the traditional pip and requirements.txt setup to using Poetry. This migration aims to streamline the development workflow, improve dependency resolution, and ensure more consistent environments across development and deployment. The changes encompass updates to Docker build processes, modifications to all installation documentation, and a restructuring of dependency definition files.

Highlights

  • Dependency Management Migration: The API's Python dependency management has been migrated from pip and requirements.txt to Poetry, enhancing developer experience and project reproducibility.
  • Dockerfile Updates: Both Dockerfile and Dockerfile-ollama-local have been updated to install Python dependencies using Poetry, including copying pyproject.toml and poetry.lock and running poetry install.
  • Documentation Updates: All relevant README.md files (including localized versions and api/README.md) have been updated to reflect the new Poetry-based installation instructions for Python dependencies.
  • File Restructuring: The api/requirements.txt file and the root pyproject.toml have been removed, replaced by a new api/pyproject.toml to centralize API dependency definitions with Poetry.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the API's dependency management from requirements.txt to Poetry, which is a great improvement for developer experience and build reproducibility. However, there are a few critical issues with incorrect version specifications for poetry and poetry-core that will cause build and installation failures. I've provided suggestions to fix these. Additionally, the installation instructions in the documentation files need to be corrected to ensure they work as intended. I've also included some recommendations to further enhance the pyproject.toml configuration.

DaniilSmirnov and others added 6 commits October 21, 2025 23:31
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@sng-asyncfunc
Copy link
Contributor

If we can get a few more thumbs up on this changes i will merge it in

@sng-asyncfunc sng-asyncfunc merged commit ac35556 into AsyncFuncAI:main Oct 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants