share tokens and new deployment process #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KillariDev
changed the base branch from
rename-0xString
to
make-things-immutable
KillariDev
force-pushed
the
sharetokens-and-new-factory-deployment-process
branch
from
aebcddb to
5683be8
Compare
MicahZoltu
approved these changes
Oct 30, 2025
Comment on lines
-12
to
+19
| address immutable owner; | ||
| address public owner; | ||
|
|
||
| event Participated(address user, uint256 repAmount, uint256 ethAmount, uint256 totalRepPurchased); | ||
| event FinalizedAuction(address user, uint256 repAmount, uint256 ethAmount); | ||
| event AuctionStarted(uint256 ethAmountToBuy, uint256 repAvailable); | ||
|
|
||
| constructor(address _owner) { | ||
| function setOwner(address _owner) external { | ||
| require(owner == address(0x0), 'owner already set!'); |
Member
There was a problem hiding this comment.
There is no way to remove the cyclic dependency that results in this being necessary? I really don't like mutable variables if there is any option for immutability. IIUC, the owner should never change, this is just necessary because you have a cyclic dependency between this contract and another?
| uint256 tokenId = shareToken.getTokenId(universeId, outcome); | ||
| uint256 amount = shareToken.burnTokenId(tokenId, msg.sender); | ||
| uint256 totalSupply = shareToken.totalSupplyForUniverse(universeId); | ||
| uint256 ethValue = amount * completeSetCollateralAmount / totalSupply; // this is wrong |
Member
There was a problem hiding this comment.
Suggested change
| uint256 ethValue = amount * completeSetCollateralAmount / totalSupply; // this is wrong | |
| uint256 ethValue = amount * completeSetCollateralAmount / totalSupply; // TODO: this is wrong |
| uint256 ethValue = amount * completeSetCollateralAmount / completeSet.totalSupply(); | ||
| completeSet.burn(msg.sender, amount); | ||
| uint256 totalSupply = shareToken.totalSupplyForUniverse(universeId); | ||
| uint256 ethValue = amount * completeSetCollateralAmount / totalSupply; // this is wrong |
Member
There was a problem hiding this comment.
Suggested change
| uint256 ethValue = amount * completeSetCollateralAmount / totalSupply; // this is wrong | |
| uint256 ethValue = amount * completeSetCollateralAmount / totalSupply; // TODO: this is wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.