Skip to content

Decoupling error handling for Document Creation #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Decoupling error handling for Document Creation #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c554010
Decoupling error handling for Document Creation Fixes AuthorizeNet/sd…
j2devcore Sep 10, 2021
3a47aeb
Adding defensive error handling to avoid exceptions if the http reque…
j2devcore May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions authorizenet/apicontrollersbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,24 @@ def execute(self):
self._httpResponse = self._httpResponse.text[3:] #strip BOM
self.afterexecute()
try:
self._response = apicontractsv1.CreateFromDocument(self._httpResponse)
self._response = apicontractsv1.CreateFromDocument(self._httpResponse)
except (pyxb.exceptions_.PyXBException, pyxb.exceptions_.PyXBError) as e:
error_details = e.details()
try:
raise e(
'Validation Error Creating Document: At %s, with Arguments: %s, details:',
type(e), e.args, str(error_details))
except TypeError:
anetLogger.error(
'Validation Error Creating Document: At %s, with Arguments: %s, details:',
type(e), e.args
)
try:
#objectify code
xmlResponse= self._response.toxml(encoding=constants.xml_encoding, element_name=self.getrequesttype())
xmlResponse = xmlResponse.replace(constants.nsNamespace1, b'')
xmlResponse = xmlResponse.replace(constants.nsNamespace2, b'')
self._mainObject = objectify.fromstring(xmlResponse)

except Exception as objectifyexception:
anetLogger.error( 'Create Document Exception: %s, %s', type(objectifyexception), objectifyexception.args )
responseString = self._httpResponse
Expand Down