Consume navigation bar insets before applying imePadding #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
etoledom
approved these changes
May 29, 2025
Contributor
etoledom
left a comment
etoledom
left a comment
There was a problem hiding this comment.
This PR completely solves the mentioned issue 🎉
Thank you for the fix 🙏
AdamGrzybkowski
force-pushed
the
adam/GRA-123
branch
from
306764c to
90d8032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@etoledom reported weird behavior in the
AltTextPagewith the keyboard shown. I narrowed it down to thepositionAwareImePadding()custom modifier. This forced me to look for alternatives, and I actually understood why we had the excessive padding in the first place. It turns out the insets are the sum of all, meaning if we setstatusBarPaddingandimePadding, both will be applied. The thing is, the keyboard handles the status bar padding itself so when it's shown we want to only have theimePaddingapplied. In order to fix that, we have to consume the padding set in the parent (the status bar padding) to make sure only the padding set in the children component is used.There should be no UI changes, except for the UI glitch that should now be gone.
Testing Steps
@etoledom I believe you now best how to test it!