Avoid split navigation on regular horizontal size class#759
Merged
Conversation
etoledom
added
Bug
|
| App Name | Gravatar Prototype Build | |
| Build Number | 2369 | |
| Version | PR #759 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | 63e0a36 | |
| Installation URL | 7u1sg4sts070o |
pinarol
approved these changes
May 21, 2025
Contributor
pinarol
left a comment
pinarol
left a comment
There was a problem hiding this comment.
Looks good. The issue is solved. 🎉
| preferenceKey: InnerHeightPreferenceKey.self | ||
| ) | ||
| } | ||
| .navigationViewStyle(StackNavigationViewStyle()) |
Contributor
There was a problem hiding this comment.
.navigationViewStyle(.stack) seems to also work.
Contributor
There was a problem hiding this comment.
Just saying this as a TIL.
Contributor
Author
There was a problem hiding this comment.
.navigationViewStyle(.stack) seems to also work.
Oh I like this one more 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #758
Description
Fixes the issue described in #758
Testing Steps