Skip to content

Adding bottom padding to error view on About editor#760

Merged
etoledom merged 1 commit intotrunkfrom
etoledom/bottom-padding-about-error
May 21, 2025
Merged

Adding bottom padding to error view on About editor#760
etoledom merged 1 commit intotrunkfrom
etoledom/bottom-padding-about-error

Conversation

@etoledom
Copy link
Contributor

Closes BETS-48

Description

Adding padding under error view on the about editor.

Now both avatar and about error views have the same space at the bottom

I've chosen to add it only under the error view, as the content already looks well laid out

Testing Steps

  • Run the demo app on an old iPhone without notch (iPhone SE)
  • Go to the Quick Editor demo screen
  • Insert an invalid auth token (to force auth error)
  • Open the Quick Editor with About Editor scope
    • Check that there's a space between the lower frame of the error and the screen.

@etoledom etoledom requested a review from pinarol May 21, 2025 12:08
@etoledom etoledom self-assigned this May 21, 2025
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@wpmobilebot
Copy link

App Icon📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar Prototype Build
Build Number2366
VersionPR #760
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commit9bf15cd
Installation URL3s6qtnpp3nqr0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@etoledom etoledom merged commit aa458e5 into trunk May 21, 2025
10 of 13 checks passed
@etoledom etoledom deleted the etoledom/bottom-padding-about-error branch May 21, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments