Move headers from URLSession level to request level#764
Merged
Conversation
To prevent them to be overridden by a custom URLSession
|
| App Name | Gravatar Prototype Build | |
| Build Number | 2378 | |
| Version | PR #764 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | 7a1fc7c | |
| Installation URL | 51q9abgqhvb40 |
etoledom
approved these changes
May 27, 2025
Contributor
etoledom
left a comment
etoledom
left a comment
There was a problem hiding this comment.
Tested a custom URLSession passed to the Profile service:
- On trunk it won't add the
x-headers - With these changes, they are added
🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Description
Currently we don't add headers in case a custom
URLSessionis injected. We might be missing some usage analytics because of that. This PR proposes to change the point we add these headers so they are not overridden/lost.Testing Steps
Use a sniffer tool to check that the headers are added both for upload and other operations.