Skip to content

Release 3.4.0 #772

Merged
etoledom merged 14 commits intotrunkfrom
release/3.4.0
Jun 23, 2025
Merged

Release 3.4.0 #772
etoledom merged 14 commits intotrunkfrom
release/3.4.0

Conversation

@etoledom
Copy link
Contributor

Description

Bumped up version to 3.4.0

Testing Steps

  • Everything under the About Editor and Avatar & About Editor scopes.

@etoledom etoledom added release Releasing a new version [Feature] Gravatar-QuickEditor Gravatar Quick Editor QE About editing labels May 30, 2025
@wpmobilebot
Copy link

wpmobilebot commented May 30, 2025

App Icon📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar Prototype Build
Build Number2442
VersionPR #772
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commit10ea47a
Installation URL4gscaifo0rua0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@andrewdmontgomery andrewdmontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some odd stuff happening with localizations. But whatever the underlying problem, I think the first step is to merge these changes into trunk anyway.

<dict>
<key>CFBundleShortVersionString</key>
<string>3.4.0-rc.1</string>
<string>3.4.0-rc.2</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to reset this

version.rb Outdated

module Gravatar
VERSION = '3.4.0-rc.1'
VERSION = '3.4.0-rc.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to reset this, too

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@andrewdmontgomery andrewdmontgomery dismissed their stale review June 23, 2025 15:31

The version has been fixed

@etoledom etoledom merged commit ba8eb18 into trunk Jun 23, 2025
8 checks passed
@etoledom etoledom deleted the release/3.4.0 branch June 23, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Gravatar-QuickEditor Gravatar Quick Editor QE About editing release Releasing a new version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments