Skip to content

Requested changes from PR review - #782

Merged
etoledom merged 7 commits into
release/3.4.0from
etoledom/pr-review-requests
Jun 13, 2025
Merged

Requested changes from PR review#782
etoledom merged 7 commits into
release/3.4.0from
etoledom/pr-review-requests

Conversation

@etoledom

@etoledom etoledom commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

Closes GRA-193

Description

  • This PR removes the email from the Quick Editor header when the token is given externally (not using internal OAuth flow).
  • Changing the arrow icon from the View profile button to an external link icon.
  • The Profile card maximum text size is .xxxl and it won't grow for accessibility sizes.
  • We have removed the profile card for text sizes of .accessibility3 and more.
  • On Avatar & About scope, the default height of the About editor is now intrinsic height.

Testing Steps

  • Run the demo app
  • Navigate to the Quick Editor demo screen
  • Open the Quick Editor with the token field blank
    • Check that the email is visible
  • Close the Quick Editor
  • Add a valid token to the token field
  • Open the Quick Editor
    • Check that the email is not visible
  • Check that the View Profile button is displaying the new external link icon instead of the arrow.

@pinarol pinarol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@wpmobilebot

Copy link
Copy Markdown
App Icon📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar Prototype Build
Build Number2433
VersionPR #782
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commitbc8e5e2
Installation URL3rr0jr2bprclg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@etoledom
etoledom merged commit ce04275 into release/3.4.0 Jun 13, 2025
@etoledom
etoledom deleted the etoledom/pr-review-requests branch June 13, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants