Conversation
Instead of doing all the installation steps for xmllint validation in the workflow, use the ✨ new dedicated `phpcsstandards/xmllint-validate` action runner instead.
Notes:
* This does mean that the `bin/xml-lint` script is now no longer used in CI.
I've left the script in place as there may be contributors who want to run these checks locally and the script can help them with that, though happy to remove the script if nobody uses it.
Ref: https://github.com/marketplace/actions/xmllint-validate
... for dev tool files.
Contributor
|
Fine to remove the script please. |
GaryJones
previously approved these changes
Mar 25, 2025
... now it is no longer used in CI.
Collaborator
Author
Done in a separate commit. |
GaryJones
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH Actions: use the xmllint-validate action runner
Instead of doing all the installation steps for xmllint validation in the workflow, use the ✨ new dedicated
phpcsstandards/xmllint-validateaction runner instead.Notes:
bin/xml-lintscript is now no longer used in CI.I've left the script in place as there may be contributors who want to run these checks locally and the script can help them with that, though happy to remove the script if nobody uses it.
Ref: https://github.com/marketplace/actions/xmllint-validate
GH Actions: add some additional XML validation checks
... for dev tool files.
🆕 Remove the bin/xml-lint script
... now it is no longer used in CI.