-
Notifications
You must be signed in to change notification settings - Fork 835
feat: Allow Android WebView admin-ajax.php CORS requests #45292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/editor-assets-endpoint-allows-videopress
Are you sure you want to change the base?
feat: Allow Android WebView admin-ajax.php CORS requests #45292
Conversation
The Jetpack mobile app block editor relies upon Android WebViews for serving local Gutenberg files. Editor requests then originate from the platform-default `https://appassets.androidplatform.net` origin. To enable `admin-ajax.php` requests from the Android app, we must allow CORS requests from this origin.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
Use a domain owned by the Jetpack project.
Ref CMM-713. Ref CMM-766. Ref CMM-767.
Proposed changes:
The Jetpack mobile app block editor relies upon Android WebViews for serving local Gutenberg files. Editor requests then originate from the platform-default
https://appassets.androidplatform.net
origin. To enableadmin-ajax.php
requests from the Android app, we must allow CORS requests from this origin.Other information:
Jetpack product discussion
pbArwn-7AD-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
See the testing instructions in the sibling PR: wordpress-mobile/GutenbergKit#181