WooCommerce Analytics: Add JSON_HEX_TAG to wp_json_encode #45393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WOOA7S-535
Proposed changes:
Add safe JSON encoding flags to inline script data that assigns to window.* globals and product prop, ensuring tags are hex-escaped while keeping slashes unescaped where appropriate.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
window.wcAnalytics
exists and contains sensible datawindow.localStorage.setItem( 'debug', 'wc-analytics*')
in the console andcheckout_view
event is fired with the correct "products" property.