Skip to content

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented Oct 7, 2025

Fixes p1759758124573359/1759158780.923629-slack-CK365S85V

Proposed changes:

Implement conditional checks for get_server_details and get_blog_details methods to support WC_Site_Tracking for versions below 6.8.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Use WC 6.8 or moved get_blog_details and get_session_details methods from ‎woocommerce/includes/tracks/class-wc-tracks.php‎ to ‎woocommerce/includes/tracks/class-wc-site-tracking.php‎
  • Go to your site frontend and check that no errors are thrown.

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/wc-analytics-undefined-methods branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/wc-analytics-undefined-methods

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 7, 2025
…details retrieval

* Implement conditional checks for `get_server_details` and `get_blog_details` methods to support WC_Site_Tracking for versions below 6.8.
* Ensure backward compatibility with existing parent class methods.
@chihsuan chihsuan force-pushed the fix/wc-analytics-undefined-methods branch from bada112 to 96e385a Compare October 7, 2025 06:44
@chihsuan chihsuan self-assigned this Oct 7, 2025
@chihsuan chihsuan added [Status] Needs Review This PR is ready for review. Bug [Type] Bug When a feature is broken and / or not performing as intended and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. Bug labels Oct 7, 2025
@chihsuan chihsuan requested a review from a team October 7, 2025 06:45
Copy link

jp-launch-control bot commented Oct 7, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/woocommerce-analytics/src/class-wc-analytics-tracking.php 0/150 (0.00%) 0.00% 9 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] WooCommerce Analytics [Package] WooCommerce Analytics Enhanced analytics for WooCommerce users [Status] Needs Review This PR is ready for review. [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant