Skip to content

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Oct 10, 2025

Close CMM-781. Close CMM-393.

Proposed changes:

  • Disable the "Your phone" media source for the GutenbergKit (mobile apps) environment, as this source makes less sense in this context and may cause confusion.
  • Disable external media sources for the GutenbergKit (mobile apps) environment, as the APIs do not currently support the token authentication and CORS requests required for that environment.
Before After
before after
before-menu N/A

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Apply these Jetpack changes to your site (see comment).
  2. Proxy your testing device requests to your sandbox server.
  3. Open the GutenbergKit editor in the mobile app.
  4. Insert an Image block.
  5. Verify the options exclude the disabled options.

@dcalhoun dcalhoun added [Status] In Progress [Type] Task [Extension] External Media Extend all block editor media tools to support external providers [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 10, 2025
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the task/disable-problematic-media-providers-for-gutenberg-kit branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack task/disable-problematic-media-providers-for-gutenberg-kit

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Sourcing media from "your phone" while using a phone's mobile app is
less useful and possibly confusing.
The external media sources currently do not support the token
authentication and CORS requests required by GutenbergKit (mobile apps).
Disabling this menu avoids presenting broken features to users. We
should re-enable these once we update the server functionality to
support the required authentication mechanisms.
@dcalhoun dcalhoun force-pushed the task/disable-problematic-media-providers-for-gutenberg-kit branch from 3a53403 to 63fb7c9 Compare October 10, 2025 13:23
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: November 4, 2025
    • Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@dcalhoun dcalhoun marked this pull request as ready for review October 10, 2025 13:38
@dcalhoun dcalhoun requested a review from adalpari October 10, 2025 13:40
@dcalhoun dcalhoun added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Oct 10, 2025
@dcalhoun dcalhoun requested review from kean and removed request for adalpari October 10, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Extension] External Media Extend all block editor media tools to support external providers [Package] External Media [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Review This PR is ready for review. [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant