-
Notifications
You must be signed in to change notification settings - Fork 835
Forms: Fix patterns required indicator issue #45495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
This revealed that WordPress was applying the deprecated block schema (INNER_BLOCKS_DEPRECATION) instead of the current one when parsing patterns. When parsing a self-closing field block from a pattern WordPress mathec it against the deprecated schema, which didn't have requiredIndicator defined, so it was stripped out even when explicitly including it in the pattern definition. I've added reqwuiredIndicator to INNER_BLOCKS_DEPRECATION so the deprecated schema recognizes it as valid.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Fixes an issue that removed the required indicator next to required fields when creating a form using a pattern.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
(required)
text next to the field label.(required)
is rendered for required fields.