Skip to content

Podcast feed: Prevent fatals when passing invalid arg to XML parser #45498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 16, 2025
Merged

Podcast feed: Prevent fatals when passing invalid arg to XML parser #45498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af0f985
Use helper function instead of accessing raw property
tbradsha Oct 14, 2025
9f82468
Add changelog
tbradsha Oct 14, 2025
f7ed1db
Prevent all emptiness
tbradsha Oct 14, 2025
f81b24d
Tweak changelog
tbradsha Oct 14, 2025
fdb9264
Update File mock class
tbradsha Oct 15, 2025
36aa205
Just kidding...
tbradsha Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions projects/plugins/jetpack/_inc/lib/class-jetpack-podcast-feed-locator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ private function is_podcast_feed( $file ) {
return true;
}

$feed_dom = $this->safely_load_xml( $file->body );
$feed_dom = $this->safely_load_xml( (string) $file->body );

// Do this as either/or but prioritise the itunes namespace. It's pretty likely
// that it's a podcast feed we've found if that namespace is present.
Expand All @@ -48,9 +48,13 @@ private function is_podcast_feed( $file ) {
* Safely loads an XML file
*
* @param string $xml A string of XML to load.
* @return DOMDocument|false A restulting DOM document or `false` if there is an error.
* @return DOMDocument|false A resulting DOM document or `false` if there is an error.
*/
private function safely_load_xml( $xml ) {
if ( empty( $xml ) ) {
return false;
}

$disable_entity_loader = PHP_VERSION_ID < 80000;

if ( $disable_entity_loader ) {
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/fix-jetpack-fatals_when_passing_invalid_arg_to_xml_parser
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

Podcast feed: Prevent fatals when content is empty.
Loading