Skip to content

Conversation

dhasilva
Copy link
Contributor

Part of FORMS-246
Follow-up to #45273 and #45487

Proposed changes:

This adds two new attributes, disableSummary and confirmationType, deprecating customThankyou without requiring a formal block deprecation. This allows for a custom message to also include the summary and simplifies the UX.
See screenshots at the bottom of the description.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1760435815738269/1759925173.540499-slack-C052XEUUBL4

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Submit existing blocks without changing them
  • Check that the post-submission screen works as expected, same as before
  • Edit an existing form, check that the "Action after submit" section matches the old behavior
  • Save and submit. Check that the post-submission screen works as expected
  • Create a new form and set the confirmation type settings.
  • Publish and submit. Check that the post-submission screen works as expected
  • Test with different settings combinations, like redirections or text with or without custom messages and summary
Before After
Screenshot from 2025-10-14 20-49-55 Screenshot from 2025-10-14 20-48-28

@dhasilva dhasilva requested a review from a team October 14, 2025 23:51
@dhasilva dhasilva self-assigned this Oct 14, 2025
@dhasilva dhasilva added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. labels Oct 14, 2025
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-action-after-submit branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-action-after-submit

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests labels Oct 14, 2025
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: November 4, 2025
    • Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Oct 15, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/blocks/contact-form/edit.tsx 0/269 (0.00%) 0.00% 9 💔
projects/packages/forms/src/contact-form/class-contact-form.php 624/1157 (53.93%) 0.42% 4 💔

Full summary · PHP report · JS report

Coverage check overridden by Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR .

@dhasilva dhasilva added the Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR label Oct 15, 2025
Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine! Maybe needs some love on the styles when the custom thank you shows.

@dhasilva dhasilva merged commit ee25f9b into trunk Oct 15, 2025
72 of 73 checks passed
@dhasilva dhasilva deleted the update/forms-action-after-submit branch October 15, 2025 15:15
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Oct 15, 2025
@github-actions github-actions bot added this to the jetpack/15.2 milestone Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Contact Form Form block (also see Contact Form label) Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants