-
Notifications
You must be signed in to change notification settings - Fork 835
Forms: Update "Action after submit" sidebar section #45502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 2 files.
Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine! Maybe needs some love on the styles when the custom thank you shows.
Part of FORMS-246
Follow-up to #45273 and #45487
Proposed changes:
This adds two new attributes,
disableSummary
andconfirmationType
, deprecatingcustomThankyou
without requiring a formal block deprecation. This allows for a custom message to also include the summary and simplifies the UX.See screenshots at the bottom of the description.
Other information:
Jetpack product discussion
p1760435815738269/1759925173.540499-slack-C052XEUUBL4
Does this pull request change what data or activity we track or use?
Testing instructions: