pass redis options through, rather than attempt to parse them#1178
Open
alex-h-strachan wants to merge 3 commits intoAutomattic:masterfrom
Open
pass redis options through, rather than attempt to parse them#1178alex-h-strachan wants to merge 3 commits intoAutomattic:masterfrom
alex-h-strachan wants to merge 3 commits intoAutomattic:masterfrom
Conversation
* no longer needed since node_redis 2.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use case - I would like to use a redis configuration like
{ url: 'my-connection-url', tls: { servername: 'my-servername' } }This is the easiest configuration for Microsoft Azure's fully managed redis. While it's possible to support this with the existing configuration it requires de-structuring the connection url, passing it through to Kue where it will be re-constructed and passed back. With this PR, the same opts can be provided to the redis.createClient() function as go to Kue.
To maintain compatibility, I've translated the options.redis.socket to the "path" argument passed to redis & I took the options.redis.options and spread them into the main configuration, so they should still be supported.