Open
Conversation
Collaborator
Project dependencies changeslist! Upgraded Dependencies
com.automattic:eventhorizon:pocket-casts-307016d85d064ca163542173f03157c6a947a081, (changed from pocket-casts-1ad1c1e10ce653841ecae96e6df1f9af7f7ea593)tree +--- project :modules:features:account
| \--- project :modules:features:search
| \--- project :modules:services:analytics
-| +--- com.automattic:eventhorizon:pocket-casts-1ad1c1e10ce653841ecae96e6df1f9af7f7ea593
+| +--- com.automattic:eventhorizon:pocket-casts-307016d85d064ca163542173f03157c6a947a081
| \--- project :modules:services:model
-| +--- com.automattic:eventhorizon:pocket-casts-1ad1c1e10ce653841ecae96e6df1f9af7f7ea593 (*)
+| +--- com.automattic:eventhorizon:pocket-casts-307016d85d064ca163542173f03157c6a947a081 (*)
| \--- project :modules:services:utils
| \--- project :modules:services:payment
-| \--- com.automattic:eventhorizon:pocket-casts-1ad1c1e10ce653841ecae96e6df1f9af7f7ea593 (*)
+| \--- com.automattic:eventhorizon:pocket-casts-307016d85d064ca163542173f03157c6a947a081 (*)
\--- project :modules:features:discover
\--- project :modules:features:podcasts
\--- project :modules:features:player
\--- project :modules:features:transcripts
\--- project :modules:services:sharing
- \--- com.automattic:eventhorizon:pocket-casts-1ad1c1e10ce653841ecae96e6df1f9af7f7ea593 (*)
+ \--- com.automattic:eventhorizon:pocket-casts-307016d85d064ca163542173f03157c6a947a081 (*) |
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates Up Next / mini-player Up Next related analytics from the legacy AnalyticsTracker events/properties approach to strongly-typed Event Horizon events (PCDROID-419), aligning tracking across UI entry points (mini player, player, Up Next surfaces).
Changes:
- Replaced legacy analytics tracking for Up Next + mini player long-press menu events with Event Horizon event types across ViewModels, fragments, adapters, and dialogs.
- Updated
UpNextSourceandUpNextSortTypeto carry Event Horizon enums (instead of string analytics values) and wired those through tracking calls. - Bumped the
eventhorizondependency version to include the needed event types.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/playback/UpNextQueue.kt | Updates UpNextSource to expose an Event Horizon source enum for typed event payloads. |
| modules/services/model/src/main/java/au/com/shiftyjelly/pocketcasts/models/type/UpNextSortType.kt | Replaces string analytics sort value with Event Horizon sort enum for UpNextSortEvent. |
| modules/features/player/src/test/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/UpNextViewModelTest.kt | Switches test setup from AnalyticsTracker.test() to EventHorizon(TestEventSink()). |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/UpNextViewModel.kt | Migrates sort tracking to UpNextSortEvent via EventHorizon. |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/PlayerViewModel.kt | Plumbs EventHorizon into ClearUpNextDialog creation. |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/dialog/MiniPlayerDialog.kt | Migrates mini player long-press menu shown/option/dismissed tracking to Event Horizon. |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/dialog/ClearUpNextDialog.kt | Migrates Up Next queue cleared tracking to UpNextQueueClearedEvent. |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/UpNextFragment.kt | Migrates Up Next events (shown, reorder, multi-select, select-all, discover) to Event Horizon and refactors args handling via @Parcelize. |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/UpNextAdapter.kt | Migrates row/footer interactions (episode tap/long-press, shuffle, now playing tap) to Event Horizon events. |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/PlayerContainerFragment.kt | Migrates Up Next shown/dismissed events for the NOW_PLAYING/player entry points. |
| gradle/libs.versions.toml | Updates Event Horizon dependency revision. |
| app/src/main/java/au/com/shiftyjelly/pocketcasts/ui/MainActivity.kt | Migrates Up Next shown/dismissed tracking for the bottom-sheet Up Next flow to Event Horizon. |
...positories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/playback/UpNextQueue.kt
Outdated
Show resolved
Hide resolved
...s/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/dialog/MiniPlayerDialog.kt
Show resolved
Hide resolved
595b477 to
aec0e7c
Compare
96c90fd to
71c07be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This migrates Up Next related events to Event Horizon.
Relates to PCDROID-419
Testing Instructions
I would mostly focus on the code review and smoke test some of these events as the migration process is rather a mechanical one.
mini_player_long_press_menu_shownmini_player_long_press_menu_option_tappedmini_player_long_press_menu_dismissedup_next_shownup_next_queue_clearedup_next_now_playing_tappedup_next_queue_episode_tappedup_next_queue_episode_long_pressedup_next_multi_select_enteredup_next_select_all_tappedup_next_multi_select_exitedup_next_queue_reorderedup_next_dismissedup_next_shuffle_enabledup_next_discover_button_tappedup_next_sortScreenshots or Screencast
N/A
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...