Skip to content

Conversation

@bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Nov 20, 2025

Fixes an issue caught in #3718 with the application of the Up Next snapshot.

When we call PlaybackManager.shared.addToUpNext, the ``UpNextButton.episodeAddedis triggered, causing animations to stack up. Instead, we should usebulkAdd` to apply the snapshot so that we don't trigger those animations.

To test

  • Create an Up Next queue with hundreds of episodes (>500) by selecting all from various podcasts and adding
  • Clear the Up Next queue
  • Go to Profile > Settings > Up Next History
  • Apply an Up Next history snapshot
  • ✅ Ensure episodes are added to Up Next queue and results are applied instantly

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added this to the 8.1 milestone Nov 20, 2025
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@pocketcasts pocketcasts modified the milestones: 8.1, 8.2 Nov 26, 2025
@pocketcasts
Copy link
Contributor

Version 8.1 has now entered code-freeze, so the milestone of this PR has been updated to 8.2.

@pocketcasts pocketcasts modified the milestones: 8.2, 8.3 Dec 8, 2025
@pocketcasts
Copy link
Contributor

Version 8.2 has now entered code-freeze, so the milestone of this PR has been updated to 8.3.

@pocketcasts pocketcasts modified the milestones: 8.3, 8.4 Jan 5, 2026
@pocketcasts
Copy link
Contributor

Version 8.3 has now entered code-freeze, so the milestone of this PR has been updated to 8.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants