Skip to content

feat(dev-env): migration from vipdev.lndo.site to vipdev.site - #851

Open
sjinks wants to merge 1 commit into
masterfrom
migrate/site-domain
Open

feat(dev-env): migration from vipdev.lndo.site to vipdev.site#851
sjinks wants to merge 1 commit into
masterfrom
migrate/site-domain

Conversation

@sjinks

@sjinks sjinks commented Aug 7, 2024

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Aug 7, 2024

Copy link
Copy Markdown

Trivy Scan Report

ghcr.io/automattic/vip-container-images/dev-tools:0.9 (alpine 3.20.3)

No vulnerabilities found.

@rebeccahum

Copy link
Copy Markdown
Contributor

How do we make sure we don't break things for existing dev-env users who aren't running on the latest CLI? 😬

@sjinks

sjinks commented Aug 19, 2024

Copy link
Copy Markdown
Member Author

@rebeccahum Images are updated independently of VIP CLI.

For the existing environments, images are re-pulled every two weeks. For new environments, they are pulled on the first start.

The idea is to merge this PR and ship Automattic/vip-cli#1984, say, in a month.

@rinatkhaziev

Copy link
Copy Markdown
Contributor

For the existing environments, images are re-pulled every two weeks. For new environments, they are pulled on the first start.

@sjinks Right, but then it means someone on the old version will download the new image and the migration routine will run for them?

@sjinks

sjinks commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

@rinatkhaziev

https://github.com/Automattic/vip-container-images/pull/851/files#diff-ad8cc8dcf9efb7506300a53b2cf5754bf370da1daa148bf33304572c6a8050f7R206

The migration routine will start if the new domain is *.vipdev.site and the siteurl mentions vipdev.lndo.site. That is, the migration will never happen for the old versions of VIP CLI.

@rinatkhaziev

Copy link
Copy Markdown
Contributor

@rebeccahum ideally we should test a bit :)

@rebeccahum

Copy link
Copy Markdown
Contributor

@rinatkhaziev testing? don't know her

@rinatkhaziev

Copy link
Copy Markdown
Contributor

Testing, please meet @rebeccahum. Rebecca, please meet Testing, our good friend.

@sjinks

sjinks commented Sep 9, 2024

Copy link
Copy Markdown
Member Author

@rebeccahum @rinatkhaziev is it ok to merge this? Or are you still having fun with Testing?

@rebeccahum

Copy link
Copy Markdown
Contributor

@sjinks Haven't reached out to Testing yet, are you able to?

@sjinks

sjinks commented Sep 9, 2024

Copy link
Copy Markdown
Member Author

I actually did :-) (like a month ago)

This is what we were doing:

  1. Create, start, and stop a new environment (it should be in vipdev.lndo.site)
  2. Update Lando config (~/.local/share/vip/lando/config.yml) and set domain: vipdev.site
  3. Make sure that no other environment is running and there's no proxy container hanging around. If they are, kill them.
  4. Restart the environment; it should say "Migrating from vipdev.lndo.site to vipdev.site, please stand by…"
  5. Make sure that the new ....vipdev.site URL works.

@rinatkhaziev

Copy link
Copy Markdown
Contributor

I'm gonna try to break it, stay tuned.

@sjinks
sjinks force-pushed the migrate/site-domain branch from 682c809 to 8b60798 Compare September 9, 2024 19:13
@github-actions

github-actions Bot commented Nov 9, 2024

Copy link
Copy Markdown

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants