Implement WpDeriveParamsField macro for automatic enum generation
#870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
approved these changes
Sep 10, 2025
Replace manual *ListParamsField enum implementations with a procedural macro
that automatically generates field enums from struct definitions.
The macro generates enums with:
- Automatic PascalCase conversion for variant names
- Support for #[field_name("custom_name")] attribute for custom serialization names
- Proper strum attributes for field serialization
Changes:
- Add wp_derive::WpDeriveParamsField procedural macro in params_field.rs
- Replace manual enum implementations across 12 API parameter structs
- Remove redundant IntoStaticStr imports (now handled by macro)
- Add comprehensive test suite with pass/fail scenarios
- Update dependencies to include convert_case and strum_macros
oguzkocer
force-pushed
the
feature/wp-derive-params-field-macro
branch
from
9a8e80f to
e00313a
Compare
|
Admin merging it as CI confirmed the changes before the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace manual
*ListParamsFieldenum implementations with a procedural macro that automatically generates field enums from struct definitions. The macro generates enums with:PascalCaseconversion for variant names#[field_name("custom_name")]attribute for custom serialization names