add ItemsSource docs in combobox.md #646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add ItemsSource [the breaking changes In V11.0](https://github.com/AvaloniaUI/Avalonia/wiki/Breaking-Changes#itemscontrol-changes-including-all-itemscontrol-inherited-controls-like-listbox-or-menus) - fix the last example - disable the compiled binding to make it work effortlessly - `GetInstalledFontFamilyNames` method is no more avalible! - use `ItemsSource` insted of `Items`
maxkatz6
reviewed
Apr 11, 2025
| <StackPanel Margin="20"> | ||
| <ComboBox x:Name="fontComboBox" SelectedIndex="0" | ||
| Width="200" MaxDropDownHeight="300"> | ||
| Width="200" MaxDropDownHeight="300" x:CompileBindings="False"> |
There was a problem hiding this comment.
Documentation shouldn't encourage users disabling compiled bindings. It's a bad (potentially app breaking) practice.
There was a problem hiding this comment.
If this PR intention is to make this work running from simple copy pasting, consider adding x:DataType with expected type in the DataTemplate, x:DataType="FontFamily" I suppose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ItemsSource the breaking changes In V11.0
fix the last example
- disable the compiled binding to make it work effortlessly
-
GetInstalledFontFamilyNamesmethod is no more avalible!- use
ItemsSourceinsted ofItems