chore(settings): ensure plugin browser install button resizes correctly#2431
Open
hthienloc wants to merge 1 commit into
Open
chore(settings): ensure plugin browser install button resizes correctly#2431hthienloc wants to merge 1 commit into
hthienloc wants to merge 1 commit into
Conversation
Fixed a visual bug where the install button would overflow its container after a plugin was installed. This was caused by the width not re-evaluating correctly and StyledText's default elide/wrap properties interfering with implicit width calculations.
hthienloc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a minor visual bug in the Plugin Browser where the install button's width would not re-evaluate correctly after a plugin was installed, causing the 'Installed' text to overflow the button's boundaries.
Changes:
elideandwrapModein theStyledTextcomponent within the install button to ensure accurateimplicitWidthreporting.widthproperty to be bound viaimplicitWidthfor better reactivity in QML.Visual Comparison
Before
After