Correct title of Theme Toggle toolbar button#578
Merged
AykutSarac merged 5 commits intoAykutSarac:mainfrom Mar 30, 2026
Merged
Conversation
Owner
|
LGTM. Can we fix the lint? |
Contributor
Author
|
The lint is fixed. |
AykutSarac
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #577
What Changed
I was using the demo app and didn't immediately recognize the Sun icon, so I found the incorrect title confusing. I changed the title attribute to say "Light Mode" or "Dark Mode" using logic consistent with how the icon is selected.
How to Test
Run the browser application and hover over the Sun/Moon toolbar button.
Evidence
Screenshot is included in the issue