-
Notifications
You must be signed in to change notification settings - Fork 644
Update charts to be compliant with AKS best practices #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update charts to be compliant with AKS best practices #247
Conversation
a7e8881 to
baab047
Compare
|
/test-e2e |
|
🚀 @pauldotyu Starting E2E tests... Workflow Run: 19866572631 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates Kubernetes manifests to align with AKS (Azure Kubernetes Service) best practices by improving configuration management and adding health probes. The changes move sensitive credentials from plaintext environment variables to Secrets and non-sensitive configuration to ConfigMaps, using envFrom for cleaner configuration injection.
Key Changes:
- Replaced individual
envvariables withenvFromreferences to ConfigMaps and Secrets for RabbitMQ and order-service - Added readiness and liveness probes to RabbitMQ container in the quickstart manifest
- Fixed missing newlines at end of Helm chart template files
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/aks-store-demo/templates/rabbitmq.yaml | Added missing newline at end of file |
| charts/aks-store-demo/templates/order-service.yaml | Added missing newline at end of file |
| charts/aks-store-demo/templates/mongodb.yaml | Added missing newline at end of file |
| aks-store-ingress-quickstart.yaml | Introduced ConfigMaps/Secrets for RabbitMQ and order-service configuration, attempted to add health probes to RabbitMQ (contains duplicate probe definitions) |
| aks-store-all-in-one.yaml | Introduced ConfigMaps/Secrets for RabbitMQ and order-service configuration using envFrom pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <[email protected]>
|
@NickKeller appreciate you looking into this! I've updated all the YAML for best-practices based on the latest version of Deployment Safeguards in a previous commit before realizing you've made some changes to the Helm chart templates. I've rebased keeping your configmap and secrets changes and running e2e tests now to confirm it'll all still work. Will resolve Copilot's comments about secrets because I don't think there is any better way around it while keeping deployments simple. |
|
✅ @pauldotyu E2E tests completed successfully! Workflow Run: 19866572631 All tests passed and resources have been cleaned up. |
Purpose
Update charts to be compliant with AKS best practices
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information