Skip to content

docs: update definition-of-done.md #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: update definition-of-done.md #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/development-guidelines/definition-of-done.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,15 @@ The following checklist must be complete before a template is published
- [ ] .devcontainer.json configuration install latest `azd` version
- [ ] Infrastructure as code is in place (`/infra` folder where applicable, manifest files or code generators in the case of `Aspire` and similar )
- [ ] Azure services configuration (/azure.yml file) is in place
- [ ] `remoteBuild` is set to `true` to enable cross-platform support, in the [template configuration](https://github.com/Azure-Samples/azd-template-artifacts/blob/main/docs/development-guidelines/template-configuration.md)
Copy link
Collaborator

@kristenwomack kristenwomack Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be configured in the devcontainer.json or in the azure.yaml file? The link goes to the dev container but I think this should be link to https://github.com/Azure-Samples/azd-ai-starter/blob/main/azure.yaml

Maybe I'm missing something?


## Functional requirements

- [ ] `azd up` successfully provisions and deploys a functional app
- [ ] GitHub Actions run tasks without errors
- [ ] DevContainer has been tested locally and runs
- [ ] Codespaces run [locally and in browser]
- [ ] All tests pass
- [ ] Playwright e2e tests are in place, to test the application has been successfully deployed, and all tests pass
Copy link
Collaborator

@kristenwomack kristenwomack Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have to be Playwright? Or could the author use a different testing framework?


In the absense of e2e tests, we kindly ask you to make sure that

Expand Down