-
Notifications
You must be signed in to change notification settings - Fork 267
re-enable e2e tests #6088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
re-enable e2e tests #6088
Conversation
does it include CI for generating daily-build? |
|
Still needing some additional changes |
2540140 to
d48d462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR re-enables previously disabled end-to-end tests by ensuring they run in playback mode during CI builds. This provides continued test coverage while avoiding the maintenance burden and resource costs of live testing. The tests now properly integrate with the recording framework to replay recorded HTTP interactions and command outputs.
Key Changes
- CI pipeline configured to force playback mode for all integration tests
- Five previously skipped tests re-enabled with proper recording session integration
- Test infrastructure updated (Azure Functions migrated to Flex Consumption plan, Container App output added)
- Production code fix for relative path handling in container app deployments
Reviewed changes
Copilot reviewed 14 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/templates/jobs/build-cli.yml | Removed Skip.LiveTest condition and hardcoded AZURE_RECORD_MODE to playback for CI |
| cli/azd/test/functional/up_test.go | Re-enabled 3 container app tests and 1 function app test with recording session integration |
| cli/azd/test/functional/vs_server_test.go | Added environment variable propagation for recording framework |
| cli/azd/test/functional/testdata/vs-server/tests/AcceptanceTests.cs | Consolidated two deployment tests into one comprehensive test |
| cli/azd/test/functional/testdata/samples/funcapp/infra/resources.bicep | Migrated to Azure Functions Flex Consumption plan with updated API versions |
| cli/azd/test/functional/testdata/samples/containerapp/infra/web.bicep | Added missing WEBSITE_URL output required by tests |
| cli/azd/test/functional/testdata/recordings/* | Updated and added recording files for playback mode testing |
| cli/azd/test/functional/publish_test.go | Re-enabled container app remote build test with proper session integration |
| cli/azd/pkg/project/service_target_containerapp.go | Fixed path handling to ensure infraRoot is absolute before joining with module name |
Enable end-to-end tests that have all been effectively disabled for various different reasons.
These tests now run only in playback mode as part of CI builds. This allows us to have continued coverage, and avoid maintenance burden of test expectations drifting over time.
Long-term, it would be nice for live testing to run separately as part of a nightly pipeline.
Fixes #6059