-
Notifications
You must be signed in to change notification settings - Fork 267
fix bug on error handling workflow #6453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug in the error handling workflow for the LLM-powered error recovery feature. The changes improve JSON parsing robustness and simplify context handling in the retry mechanism.
Key changes:
- Removed complex context cancellation handling (
context.WithoutCanceland per-retry context creation) - Enhanced JSON extraction to handle LLM responses with embedded JSON objects
- Updated feature description to document error handling workflow support
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cli/azd/resources/alpha_features.yaml | Updated LLM feature description to mention error handling workflows |
| cli/azd/cmd/middleware/error.go | Simplified context handling in retry logic and added fallback JSON extraction for non-pure JSON responses |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
fix bug found during tests:
For https://github.com/Azure/azure-dev/pull/6313/files#r2593740401, parent context is removed since #6446 fixed same error.