PR Review Changes: Updating ParseGithubUrl func #6476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZubaeyrMSFT
requested review from
JeffreyCA,
danieljurek,
hemarina,
rajeshkamal5050,
tg-msft,
vhvb1989,
wbreza and
weikanglim
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the GitHub URL parsing functionality by replacing a local 79-line parseGitHubUrl function with an RPC call to the core azd CLI's ParseGitHubUrl method. This centralizes the URL parsing logic and removes code duplication.
Key changes:
- Replaced local
parseGitHubUrlfunction with RPC call toazdClient.Project().ParseGitHubUrl() - Removed unused
armresourcesdependency from go.mod - Updated core azd CLI dependency and related golang.org/x packages
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cli/azd/extensions/azure.ai.finetune/internal/cmd/init.go | Replaced local parseGitHubUrl function (79 lines) with RPC call to azd client; added proper resource cleanup with defer |
| cli/azd/extensions/azure.ai.finetune/go.mod | Updated azd CLI dependency version and moved braydonk/yaml from indirect to direct; removed unused armresources dependency |
| cli/azd/extensions/azure.ai.finetune/go.sum | Updated checksums for new dependency versions including azd CLI, golang.org/x packages |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
JeffreyCA
approved these changes
Jan 8, 2026
Member
|
/azp run azure-dev - cli |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
achauhan-scc
approved these changes
Jan 9, 2026
achauhan-scc
added a commit
that referenced
this pull request
Jan 10, 2026
* Moving code Azure fork (#6429) * adding draft for fine tuning * adding service target * fixing root command format * cleaning unused commands and adding operation/sub-operation commands * adding more details to command * fixes for relative path * adding registry entry * adding git download * adding 0.0.3 * fixing bug in deploy * adding printing format * re-structuring code * adding 0.0.5 * 0.0.6 * adding low level design details * fixing ext for build * adding restructured code * reverting any registry changes * Refactoring jobs list command to align with the LLD | Add retry, environment and validation utils (#6430) * initial changes * Add retry util for exponential backoff with jitter strategy * Clean-up * Standardize CLI text to lowercase conventions, and remove redundant error messages * Address comments * Add common util for fetch environment variables * Cosmetic changes * Cosmetic changes 2 * Fix runtime error * Fix error message format * Refactoring jobs show command to align with the LLD (#6434) * Create command implementation for FineTuning CLI (#6437) * Create command for ft cli * handling null pointer for state * removing changes from old converter and yaml logic * pr review changes + scheme implementation for job params * a few formatting changes * removing ofAuto value for hyperparameters * more formatting changes * adding command line parameters + formatting * minor merge fixes * Build and Release Pipelines for Finetuning CLI (#6449) * Adding pipeline scripts * Adding pipeline scripts * fixing version path * fixing build command * adding init command (#6442) * adding init command * update version * network isloation changes. (#6458) * Adding pipeline scripts * Adding pipeline scripts * fixing version path * fixing build command * Djurek/test-network-isolation (#6455) * Update 1es-redirect.yml * Trivial change to test pipeline * Show GOPROXY * Use golang internalModuleProxy --------- Co-authored-by: Daniel Jurek <[email protected]> * Cleaning code to raise a PR to main (#6457) * adding init command * update version * cleaning some code * updating version to 0.0.7-preview (#6462) * Rename changelog.md to CHANGELOG.md * adding copyright header text * applying pr review suggestion: remove providers section from extension.yaml Co-authored-by: JeffreyCA <[email protected]> * updating version.txt to 0.0.8-preview * simplying utils for file check * reanming _uploadFile to uploadFile Co-authored-by: JeffreyCA <[email protected]> * removing duplicate import * removing unnecessary todo * Adding cspell dict * updating cspell.yaml * updating cspell.yaml * Updating finetune word in global cspell.yaml * PR Review Changes: Updating ParseGithubUrl func (#6476) * Updating parseGithubUrl func * updating resource prompt logic * copilot suggestion to remove unused variable Co-authored-by: Copilot <[email protected]> * gh copilot suggestion Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * Updating extension name in read me file. (#6483) * adding init command * update version * cleaning some code * updating readme * resolving review comments * resolving review comments * using arm resourceId parser * Finetuning CLU - Using OSS package go-retry instead of custom logic (#6485) * Using oss go-retry package * fixing retry count * Allowing user to override the fine tuning route (#6484) * adding init command * update version * cleaning some code * updating readme * allowing fine tuning routes to be overriden by envrionment variables * spell check fix (#6486) * adding init command * update version * cleaning some code * updating readme * allowing fine tuning routes to be overriden by envrionment variables * fixing spell check issues --------- Co-authored-by: saanikaguptamicrosoft <[email protected]> Co-authored-by: Zubairuddin Mohammed <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: JeffreyCA <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.