Skip to content

Add RestartAsync at Durable Functions Isolated #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 15, 2025
Merged

Add RestartAsync at Durable Functions Isolated #3147

merged 19 commits into from
Sep 15, 2025
+353 −25

Conversation

nytian
Copy link
Collaborator

@nytian nytian commented Jul 2, 2025 •
edited
Loading

Issue describing the changes in this PR

resolves #2903

  • Added the new RestartAsync support from DurableTaskClient.
  • Updated the HTTP management payload to include a RestartPostUri for orchestration restart.
  • Add E2E tests for this scenario.

Note: This PR won't work unless v1.14.0 of dotnet sdk including microsoft/durabletask-dotnet#456 released.

Related PR:

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v2.x branch.
    • Otherwise: This change applies exclusively to WebJobs.Extensions.DurableTask v3.x. It will be retained only in the dev and main branches and will not be merged into the v2.x branch.

@nytian nytian requested review from jviau and cgillum July 2, 2025 23:49
jviau
jviau previously requested changes Jul 3, 2025
View reviewed changes
@cgillum cgillum mentioned this pull request Jul 7, 2025
Open
@nytian nytian mentioned this pull request Aug 7, 2025
Merged
@nytian nytian requested a review from jviau August 7, 2025 19:38
@nytian nytian marked this pull request as draft September 12, 2025 18:25
@nytian nytian marked this pull request as ready for review September 12, 2025 21:10
cgillum
cgillum approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - no blockers - just a few minor things.

test/e2e/Apps/BasicPython/extensions.csproj
@@ -11,7 +11,7 @@
<ItemGroup>
<!-- This reference will be dynamically updated by build-e2e-tests.ps1 as part of test setup. -->
<!-- Do not commit changes to this line unless necessary -->
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.DurableTask" Version="3.3.0" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.DurableTask" Version="3.5.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but should these be project references instead of package references so that we don't have to remember to update them? @andystaples

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can open a separate PR for this, or @andystaples if you’d prefer. For now, it’s auto-generated by running build-e2e-test.ps1 locally.

jviau
jviau reviewed Sep 15, 2025
View reviewed changes
Copy link
Contributor

@jviau jviau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resetting review

@jviau jviau dismissed their stale review September 15, 2025 21:51

Resetting review

@nytian nytian merged commit 87ce252 into dev Sep 15, 2025
16 checks passed
@nytian nytian deleted the nytian/restart branch September 15, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviau jviau jviau left review comments

@cgillum cgillum cgillum approved these changes

@bachuv bachuv bachuv approved these changes

@andystaples andystaples Awaiting requested review from andystaples

@sophiatev sophiatev Awaiting requested review from sophiatev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restart not support in Isolated mode
4 participants
@nytian @cgillum @jviau @bachuv