[WIP] Create Private Package for Scale Controller#3185
Draft
nytian wants to merge 16 commits intonytian/v3.1.0from
Draft
[WIP] Create Private Package for Scale Controller#3185nytian wants to merge 16 commits intonytian/v3.1.0from
nytian wants to merge 16 commits intonytian/v3.1.0from
Conversation
…TaskTargetScaler When DurableTaskMetricsProvider.GetMetricsAsync() fails to obtain a heartbeat (e.g., PulseAsync throws or hasn't run yet), the ControlQueueLengths property on DurableTaskTriggerMetrics remains null. DurableTaskTargetScaler then passes this null value to JsonConvert.DeserializeObject, which throws: System.ArgumentNullException: Value cannot be null. (Parameter 'value') This generates ~640 million error events per day in ScaleControllerEvents across 12,000+ function apps. Fix: Add a null/empty check before deserializing ControlQueueLengths. When null or empty, treat control queue metrics as zero (no orchestrator messages), which is the correct behavior since no heartbeat data is available. Added test cases for null and empty ControlQueueLengths scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Don't merge this PR
This branch is to create private package for Scale Controller and this PR is mainly for test running.
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.csdevandmainbranches and will not be merged into thev2.xbranch.