Skip to content

Upgrade Azure SDK BOM to 1.3.6 and pin msal4j 1.24.1 for sovereign cloud support #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanmaya-panda1 merged 4 commits into from
Apr 28, 2026
Merged

Upgrade Azure SDK BOM to 1.3.6 and pin msal4j 1.24.1 for sovereign cloud support #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b46abe0
Initial plan
Copilot Apr 15, 2026
3921c83
Upgrade azure-bom-version and pin msal4j 1.24.1 for sovereign cloud s…
Copilot Apr 15, 2026
a8f6692
Address review comments: pin msal4j in quickstart, drop redundant BOM…
Apr 27, 2026
45a5cbb
Restore explicit azure-bom-version 1.3.6 in ingest-v2/pom.xml for cla…
Copilot Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ingest-v2/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
EventHouse on Fabric
</description>
<properties>
<azure-bom-version>1.2.37</azure-bom-version>
<azure-bom-version>1.3.6</azure-bom-version>
<awaitility.version>4.3.0</awaitility.version>
<kotlin.code.style>official</kotlin.code.style>
<kotlin.version>2.2.10</kotlin.version>
Comment on lines 12 to 16
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says ingest-v2/pom.xml updates azure-bom-version to 1.3.6, but the change here removes the module-level azure-bom-version property entirely. If the intent is to inherit ${azure-bom-version} from the parent, please update the PR description (or leave an explicit override here) so the change is accurately documented for reviewers and future maintainers.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

@tanmaya-panda1 tanmaya-panda1 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown
Contributor Author

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored the explicit azure-bom-version=1.3.6 override in ingest-v2/pom.xml so the upgrade intent is clearly documented in the file itself (commit 45a5cbb). It still inherits from the parent, but the explicit pin makes it unambiguous for future maintainers.

Expand Down
12 changes: 11 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
<revision>8.0.0</revision> <!-- CHANGE THIS to adjust project version-->
<ingest-v2.revision>0.0.1-beta</ingest-v2.revision> <!-- CHANGE THIS to adjust ingest-v2 version --> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.version>11</java.version>
<azure-bom-version>1.2.28</azure-bom-version>
<azure-bom-version>1.3.6</azure-bom-version>
<msal4j.version>1.24.1</msal4j.version>
<!-- Versions below are for several dependencies we're using in the data & ingest modules -->
<!-- Ideally, versions below should align with latest databricks runtime dependency versions -->
<!-- Compile dependencies -->
Expand Down Expand Up @@ -70,6 +71,15 @@
<module>samples</module>
<module>quickstart</module>
</modules>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.microsoft.azure</groupId>
<artifactId>msal4j</artifactId>
<version>${msal4j.version}</version>
</dependency>
</dependencies>
</dependencyManagement>
<build>
<plugins>
<plugin>
Expand Down
8 changes: 7 additions & 1 deletion quickstart/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@
<slf4j.version>1.8.0-beta4</slf4j.version>
<json.version>20201115</json.version>
<ingest-v2.revision>0.0.1-beta</ingest-v2.revision>
<azure-identity.version>1.18.1</azure-identity.version>
<azure-identity.version>1.18.2</azure-identity.version>
<msal4j.version>1.24.1</msal4j.version>
</properties>

Comment on lines +44 to 47
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quickstart is explicitly standalone (no <parent>), so it does not inherit the root dependencyManagement that pins com.microsoft.azure:msal4j to 1.24.1. Since this module directly depends on azure-identity, it can still resolve an older transitive msal4j, undermining the sovereign-cloud fix for the quickstart artifact. Consider adding the same msal4j version pin (e.g., via <dependencyManagement> or an explicit dependency) in this POM, or switching to inherit from the root parent POM so the pin applies automatically.

Suggested change
<azure-identity.version>1.18.2</azure-identity.version>
</properties>
<azure-identity.version>1.18.2</azure-identity.version>
<msal4j.version>1.24.1</msal4j.version>
</properties>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.microsoft.azure</groupId>
<artifactId>msal4j</artifactId>
<version>${msal4j.version}</version>
</dependency>
</dependencies>
</dependencyManagement>

Copilot uses AI. Check for mistakes.
<build>
Expand Down Expand Up @@ -113,6 +114,11 @@
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>com.microsoft.azure</groupId>
<artifactId>msal4j</artifactId>
<version>${msal4j.version}</version>
</dependency>
</dependencies>
</dependencyManagement>

Expand Down
Loading